Re: [PATCH] removes unused variable from kernel/sysctl.h

[Jaswinder Singh Rajput]

Hello Sukanto,

On Thu, 2009-04-16 at 23:22 +0530, Sukanto Ghosh wrote:
> This patch removes the unused variable 'val' from the
> __do_proc_dointvec() function
> in kernel/sysctl.h. The integer has been declared and used as 'val =
> -val' and there is
> no reference to it anywhere.
> Although I am this doesn't affects the kernel binary because gcc
> removes it, still it
> might be confusing for people reading the code.
> 

This patch is already submitted by Tomohiro Kusumi on Thu Dec 27 2007:

http://lkml.indiana.edu/hypermail/linux/kernel/0712.3/0557.html

> 
> Signed-off-by: Sukanto Ghosh <sukanto.cse.iitb@xxxxxxxxx>
> 
> ----
> 
> --- linux-2.6.29.1/kernel/sysctl.c.orig 2009-04-16 19:57:21.000000000 +0530
> +++ linux-2.6.29.1/kernel/sysctl.c      2009-04-16 19:58:26.000000000 +0530
> @@ -2198,7 +2198,7 @@ static int __do_proc_dointvec(void *tbl_
>                   void *data)

This is a very old function and have almost no git history, its old name
was do_proc_dointvec on 2005-04-16 15:20:36 when git tree was made and
then only(almost) function name is changed.

>  {
>  #define TMPBUFLEN 21
> -       int *i, vleft, first=1, neg, val;
> +       int *i, vleft, first=1, neg;
>         unsigned long lval;
>         size_t left, len;
> 
> @@ -2251,8 +2251,6 @@ static int __do_proc_dointvec(void *tbl_
>                         len = p-buf;
>                         if ((len < left) && *p && !isspace(*p))
>                                 break;
> -                       if (neg)
> -                               val = -val;

So you need to do further investigation. Is this a typo or some other
mistake.

--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/