Re: [PATCH 2/5] tracing/events: add startup tests for events

[Steven Rostedt]

On Thu, 16 Apr 2009, Frederic Weisbecker wrote:
> > +	sysname = kmalloc(4, GFP_KERNEL);
> > +	if (WARN_ON(!sysname)) {
> > +		pr_warning("Can't allocate memory, giving up!\n");
> > +		return 0;
> > +	}
> > +	memcpy(sysname, "*:*", 4);
> > +	ret = ftrace_set_clr_event(sysname, 1);
> > +	if (WARN_ON_ONCE(ret)) {
> > +		kfree(sysname);
> > +		pr_warning("error enabling all events\n");
> > +		return 0;
> > +	}
> > +
> > +	event_test_stuff();
> > +
> > +	/* reset sysname */
> > +	memcpy(sysname, "*:*", 4);
> 
> 
> 
> Nano thing, because you are using it twice:
> Why not strcpy?
> 

Because cut and paste was so much easier ;-)

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/