Re: Fix quilt merge error in acpi-cpufreq.c

[Ingo Molnar]

* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Wed, 15 Apr 2009, Linus Torvalds wrote:
> > 
> > wouldn't you agree? Adding a "Impact: cleanup" wouldn't do 
> > anything to it, except make it not read as good English any 
> > more.
> > 
> > I like seeing explanations that read well.
> 
> Btw, I suspect that if the "Impact:" line is at the end, along 
> with the "Signed-off-by:" etc lines, it wouldn't be as disturbing 
> and I wouldn't react as negatively to it.
> 
> At least then it wouldn't break up the narrative, and it would 
> kind of fit with all the other "tagged" lines.

Yeah, that makes sense.

Or perhaps make it fit into the narrative but still have a 
recognizable structure to make sure it cannot be forgotten?

Something like:

 The impact of this change is that the build is fixed.
 The impact of this change is that the code gets cleaner.
 The impact of this change is that the CPU does not overheat.

although this sounds extremely artificial, circumvent and childish 
to me :-/

I guess i'm infected with the "Impact: " language already and my 
brain resists lingual inefficiencies ;-/ We've been using it for 
almost a year meanwhile.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/