Re: [PATCH] FRV: Fix the section attribute on UP DECLARE_PER_CPU()

[David Howells]

Ingo Molnar <mingo@xxxxxxx> wrote:

> > > Please create include/linux/percpu_types.h for basic data types 
> > > and simple, self-sufficient primitives. Also have an 
> > > include/linux/percpu_api.h or include/linux/percpu.h include 
> > > file for convenience/speedup inlines. The latter will only be 
> > > included in .c files, where 'combination' of type spaces is not 
> > > a problem.
> > 
> > Not so.  The problem is that various header files make use of 
> > per-cpu variable accessors (asm/current.h and asm/thread_info.h to 
> > name a couple) to build inline asm.
> 
> Hm, what portion did you mark with 'not so'?

The statement that "The latter will only be included in .c files, where
'combination' of type spaces is not a problem".

> I dont disagree, but i'd like to warn that such patches need _way_ 
> more testing, these are never same-day obvious patches.

I can't argue with that.

I'd like Linus to pull my first patch, if he will.  That'll at least allow FRV
to build.  Could you review it?  That's the email that started this thread,
ensubjected:

	[PATCH] FRV: Fix the section attribute on UP DECLARE_PER_CPU()

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/