Re: [PATCH v2] crypto: add self-tests for rfc4309(ccm(aes))

[Herbert Xu]

On Mon, Apr 13, 2009 at 07:11:00PM -0400, Jarod Wilson wrote:
>
> +			case -EBADMSG:
> +				if (template[i].novrfy)
> +					/* verification failure was expected */
> +					goto next_aead_vector;
>  				/* fall through */

We should also fail if novrfy is true and we get a 0 return value.

I'd also prefer to have the novrfy infrastructure changes to go
into a separate patch.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/