Re: panic on rmmod of nf_conntrack_irc

From: Patrick McHardy
Date: Tue Apr 14 2009 - 08:17:04 EST


Eric Dumazet wrote:
Patrick McHardy a écrit :
Mariusz Kozlowski wrote:
netfilter: nf_conntrack: use SLAB_DESTROY_BY_RCU and get rid of
call_rcu()
Thanks for the report. Does this patch fix it?


Hi Patrick, sorry for the delay, I was in holidays.

No problem, me too :)

I should have used different fields names (from "next", "first", ...) to catch this
kind of errors at compile time :(
>
Something like :

Thanks Eric. I guess at this point it doesn't really matter anymore
for the upstream kernel, but I'll apply your patch after getting
confirmation from Mariusz to make sure that people maintaining
external patches will notice the change (and won't send me broken
patches :)).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/