Re: [PATCH] lockdep: warn about lockdep disabling after kerneltaint, fix

[Heiko Carstens]

On Tue, 14 Apr 2009 11:15:38 +0200
Ingo Molnar <mingo@xxxxxxx> wrote:
> Subject: [PATCH] lockdep: warn about lockdep disabling after kernel taint, fix
> 
> Impact: build fix
> 
> Stephen Rothwell reported that the Sparc build broke:
> 
>  In file included from kernel/panic.c:12:
>  include/linux/debug_locks.h: In function '__debug_locks_off':
>  include/linux/debug_locks.h:15: error: implicit declaration of function 'xchg'
> 
> due to:
> 
>  9eeba61: lockdep: warn about lockdep disabling after kernel taint
> 
> There is some inconsistency between architectures about where exactly
> xchg() is defined. Most have it in system.h but also in atomic.h (which
> is arguably the more logical point for it). Some, such as Sparc only
> have it in asm/system.h and not available via asm/atomic.h.
> 
> Use the widest set of headers in debug_locks.h and also include asm/system.h.
> 
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Acked-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> ---
>  include/linux/debug_locks.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
> index 493dedb..29b3ce3 100644
> --- a/include/linux/debug_locks.h
> +++ b/include/linux/debug_locks.h
> @@ -3,6 +3,7 @@
> 
>  #include <linux/kernel.h>
>  #include <asm/atomic.h>
> +#include <asm/system.h>

Ah, ok. Please ignore my other mail from a few seconds ago ;)
This fixes the s390 build break. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/