Re: [PATCH 2/7] use smp_call_function_single() inarch/x86/kernel/acpi/cstate.c

[Ingo Molnar]

* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Mon, 13 Apr 2009 09:30:02 +0930 Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> 
> > From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > 
> > Attempting to rid us of the problematic work_on_cpu().  Just use
> > smp_call_function_single() here.
> > 
> > (Includes fix from Wu Fengguang <fengguang.wu@xxxxxxxxx>)
> > 
> > Cc: Ingo Molnar <mingo@xxxxxxx>
> > Cc: Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx>
> > Cc: Len Brown <len.brown@xxxxxxxxx>
> > Cc: Zhao Yakui <yakui.zhao@xxxxxxxxx>
> > Cc: Wu Fengguang <fengguang.wu@xxxxxxxxx>
> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> 
> fyi, my canonical not-documented-anywhere format for atttributing the
> folded-in fixups is:
> 
> [fengguang.wu@xxxxxxxxx: short description goes here]
> Cc: Ingo Molnar <mingo@xxxxxxx>
> Cc: Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx>
> Cc: Len Brown <len.brown@xxxxxxxxx>
> Cc: Zhao Yakui <yakui.zhao@xxxxxxxxx>
> Cc: Wu Fengguang <fengguang.wu@xxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> 
> and to include that person's Signed-off-by:, if it was provided.

It might not be documented anywhere but it is obvious hence 
self-documenting so i've been using your scheme for quite some time 
for fix foldbacks. Works very well IMO.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/