Re: mmotm 2009-04-10-02-21 uploaded - forkbombed by work_for_cpu

From: Ingo Molnar
Date: Mon Apr 13 2009 - 13:42:44 EST



* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> > I think Andrew has a stack of fixes queued up, one of which
> > should solve this problem too - which Mike tested - as the
> > commit from Andrew has caused another regression as well.
> >
> > There's no sha1 - the patch is in this thread on lkml:
> >
> > sysbench(oltp)+mysql 10% regression with 2.6.30-rc1
> >
> > | From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > |
> > | Atttempting to rid us of the problematic work_on_cpu(). Just use
> > | smp_call_fuction_single() here.
> > |
> > | This repairs a 10% sysbench(oltp)+mysql regression which Mike
> > | reported,
> >
>
> Yup. It's presently in Len's hands. And Rusty's.
>
> Vladis, perhaps you can verify?

I have not tested it but it looks good and the use of a much more
atomic primitive can only improve the situation - so unless there's
something suspicious about it i'd suggest for Linus to pick this up
from email, before -rc2.

Acked-by: Ingo Molnar <mingo@xxxxxxx>

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/