Re: [PATCH 1/2] tracing, boottrace: Move include/trace/boot.h toinclude/linux/boottrace.h

[Frederic Weisbecker]

On Mon, Apr 13, 2009 at 11:54:11AM +0800, Zhaolei wrote:
> Impact: refactor code, no functionality changed
> 
> Files in include/trace/ should be definition of tracepoints, and header
> file for boot trace should put to include/linux/.
> 
> Signed-off-by: Zhao Lei <zhaolei@xxxxxxxxxxxxxx>
> ---



Until now I had the opinion that it's good to let every tracing headers
to be placed in include/trace/* because they are not useful for anything
else than the tracer itself so that we don't encumber include/linux for
private things.

So that we have both tracepoints/trace_events plus the low-level tracers
headers in include/trace/*

I'm not opposite to this change, but seeing this patch and the recent divide
of kmemtrace headers, I would like to know the opinion of Ingo and Steven
about the strict role of include/trace/*
Is it only for tracepoints-like bits, or oslo intended for every private tracing
purposes?


Thanks.


>  include/{trace/boot.h => linux/boottrace.h} |    0 
>  init/main.c                                 |    2 +-
>  kernel/trace/trace.h                        |    2 +-
>  3 files changed, 2 insertions(+), 2 deletions(-)
>  rename include/{trace/boot.h => linux/boottrace.h} (100%)
> 
> diff --git a/include/trace/boot.h b/include/linux/boottrace.h
> similarity index 100%
> rename from include/trace/boot.h
> rename to include/linux/boottrace.h
> diff --git a/init/main.c b/init/main.c
> index 694a563..d7d4741 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -66,7 +66,7 @@
>  #include <linux/ftrace.h>
>  #include <linux/async.h>
>  #include <linux/kmemtrace.h>
> -#include <trace/boot.h>
> +#include <linux/boottrace.h>
>  
>  #include <asm/io.h>
>  #include <asm/bugs.h>
> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> index ce6bdc4..5b654ce 100644
> --- a/kernel/trace/trace.h
> +++ b/kernel/trace/trace.h
> @@ -8,7 +8,7 @@
>  #include <linux/ring_buffer.h>
>  #include <linux/mmiotrace.h>
>  #include <linux/ftrace.h>
> -#include <trace/boot.h>
> +#include <linux/boottrace.h>
>  #include <linux/kmemtrace.h>
>  #include <trace/power.h>
>  
> -- 
> 1.5.5.3
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/