Re: [PATCH] parport: Use the PCI IRQ if offered

From: Kyle McMartin
Date: Mon Apr 13 2009 - 00:47:05 EST


On Tue, Apr 07, 2009 at 03:30:57PM +0100, Alan Cox wrote:
> PCI parallel port devices can IRQ share so we should stop them hogging the
> line and making a mess on modern PC systems. We know the sharing side works
> as the PCMCIA driver has shared the parallel port IRQ for some time.
>
> Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>

> +extern struct parport *parport_pc_probe_port(unsigned long base,
> + unsigned long base_hi,
> + int irq, int dma,
> + struct device *dev,
> + int irqflags);
> +extern void parport_pc_unregister_port(struct parport *p);
>

You missed a bunch of uses of parport_pc_probe_port and broke the build
on powerpc, sparc, parisc, and probably several more.

regards, Kyle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/