Re: [PATCH]ibft: Fix the display of a few fields in the NIC attribute structure in sysfs

[Ashutosh Naik]

On Sat, Apr 11, 2009 at 11:26 PM, James Bottomley
<James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:

> What do these signoffs mean?

I am reattaching the patch here:

Description:This patch fixes the display of a few fields in the iBFT
NIC attribute
structure in sysfs.

Signed-off-by: Ashutosh Naik <ashutosh.naik@xxxxxxxxx>
Cc: Vishnu V<vishnu@xxxxxxxxxxx>

> The second question is who picks this up?  The drivers/firmware
> directory doesn't seem to have a dedicated tree, so I can take this
> through the SCSI tree if required or Andrew can take it through -mm.

This is used for display of the various structures of the iBFT table
via sysfs and can be picked up by any iSCSI initiator driver module
that uses the information in the iBFT table to boot over iSCSI, such
as open-iscsi.
diff -ruN linux-2.6.29.1-orig/drivers/firmware/iscsi_ibft.c linux-2.6.29.1/drivers/firmware/iscsi_ibft.c
--- linux-2.6.29.1-orig/drivers/firmware/iscsi_ibft.c	2009-04-11 18:25:40.000000000 +0530
+++ linux-2.6.29.1/drivers/firmware/iscsi_ibft.c	2009-04-11 18:33:42.000000000 +0530
@@ -754,11 +754,11 @@
 		rc = 1;
 		break;
 	case ibft_eth_ip_addr:
-		if (!memcmp(nic->dhcp, nulls, sizeof(nic->dhcp)))
+		if (memcmp(nic->ip_addr, nulls, sizeof(nic->ip_addr)))
 			rc = 1;
 		break;
 	case ibft_eth_subnet_mask:
-		if (!memcmp(nic->dhcp, nulls, sizeof(nic->dhcp)))
+		if (nic->subnet_mask_prefix)
 			rc = 1;
 		break;
 	case ibft_eth_origin: