Re: [PATCH 45/56] scsi: Remove void casts

[Bert Wesarg]

On Wed, Apr 8, 2009 at 13:22, Jack Stone <jwjstone@xxxxxxxxxxx> wrote:
> Remove uneeded void casts
>
> Signed-Off-By: Jack Stone <jwjstone@xxxxxxxxxxx>
> ---
> Âdrivers/scsi/aic7xxx/aic79xx_core.c     |  Â4 ++--
> Âdrivers/scsi/aic7xxx/aic7xxx_core.c     |  Â7 +++----
> Âdrivers/scsi/aic7xxx/aicasm/aicasm.c    Â|  10 +++++-----
> Âdrivers/scsi/aic7xxx/aicasm/aicasm_symbol.c | Â Â4 ++--
> Âdrivers/scsi/aic7xxx_old.c         Â|  Â3 +--
> Âdrivers/scsi/ibmvscsi/ibmvscsi.c      Â|  Â3 +--
> Âdrivers/scsi/ibmvscsi/ibmvstgt.c      Â|  Â2 +-
> Âdrivers/scsi/lpfc/lpfc_hbadisc.c      Â|  Â3 +--
> Âdrivers/scsi/lpfc/lpfc_init.c        |  Â4 ++--
> Âdrivers/scsi/lpfc/lpfc_nportdisc.c     Â|  Â4 ++--
> Âdrivers/scsi/lpfc/lpfc_sli.c        Â|  Â8 ++++----
> Âdrivers/scsi/osst.c             |  Â6 +++---
> Âdrivers/scsi/scsi_debug.c          |  Â2 +-
> Â13 files changed, 28 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drivers/scsi/aic7xxx/aic79xx_core.c
> index 63b521d..01f6d6f 100644
> --- a/drivers/scsi/aic7xxx/aic79xx_core.c
> +++ b/drivers/scsi/aic7xxx/aic79xx_core.c
> @@ -6932,12 +6932,12 @@ ahd_alloc_scbs(struct ahd_softc *ahd)
> Â Â Â Â Â Â Â Âint error;
> Â#endif
>
> - Â Â Â Â Â Â Â next_scb = (struct scb *)malloc(sizeof(*next_scb),
> + Â Â Â Â Â Â Â next_scb = malloc(sizeof(*next_scb),
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ÂM_DEVBUF, M_NOWAIT);
Dito.

> Â Â Â Â Â Â Â Âif (next_scb == NULL)
> Â Â Â Â Â Â Â Â Â Â Â Âbreak;
>
> - Â Â Â Â Â Â Â pdata = (struct scb_platform_data *)malloc(sizeof(*pdata),
> + Â Â Â Â Â Â Â pdata = malloc(sizeof(*pdata),
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â M_DEVBUF, M_NOWAIT);
Dito.

> Â Â Â Â Â Â Â Âif (pdata == NULL) {
> Â Â Â Â Â Â Â Â Â Â Â Âfree(next_scb, M_DEVBUF);
> diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c
> index e6f2bb7..a46800d 100644
> --- a/drivers/scsi/aic7xxx/aic7xxx_core.c
> +++ b/drivers/scsi/aic7xxx/aic7xxx_core.c
> @@ -2152,7 +2152,7 @@ ahc_alloc_tstate(struct ahc_softc *ahc, u_int scsi_id, char channel)
> Â Â Â Â && ahc->enabled_targets[scsi_id] != master_tstate)
> Â Â Â Â Â Â Â Âpanic("%s: ahc_alloc_tstate - Target already allocated",
> Â Â Â Â Â Â Â Â Â Â Âahc_name(ahc));
> - Â Â Â tstate = (struct ahc_tmode_tstate*)malloc(sizeof(*tstate),
> + Â Â Â tstate = malloc(sizeof(*tstate),
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â M_DEVBUF, M_NOWAIT);
Dito.

> Â Â Â Âif (tstate == NULL)
> Â Â Â Â Â Â Â Âreturn (NULL);
> @@ -5014,7 +5013,7 @@ ahc_alloc_scbs(struct ahc_softc *ahc)
> Â#ifndef __linux__
> Â Â Â Â Â Â Â Âint error;
> Â#endif
> - Â Â Â Â Â Â Â pdata = (struct scb_platform_data *)malloc(sizeof(*pdata),
> + Â Â Â Â Â Â Â pdata = malloc(sizeof(*pdata),
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â M_DEVBUF, M_NOWAIT);
Dito.

> Â Â Â Â Â Â Â Âif (pdata == NULL)
> Â Â Â Â Â Â Â Â Â Â Â Âbreak;
> diff --git a/drivers/scsi/ibmvscsi/ibmvstgt.c b/drivers/scsi/ibmvscsi/ibmvstgt.c
> index e2dd6a4..8d52a03 100644
> --- a/drivers/scsi/ibmvscsi/ibmvstgt.c
> +++ b/drivers/scsi/ibmvscsi/ibmvstgt.c
> @@ -852,7 +852,7 @@ static int ibmvstgt_probe(struct vio_dev *dev, const struct vio_device_id *id)
> Â Â Â Âif (err)
> Â Â Â Â Â Â Â Âgoto put_host;
>
> - Â Â Â dma = (unsigned int *) vio_get_attribute(dev, "ibm,my-dma-window",
> + Â Â Â dma = vio_get_attribute(dev, "ibm,my-dma-window",
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â &dma_size);
Dito.

> Â Â Â Âif (!dma || dma_size != 40) {
> Â Â Â Â Â Â Â Âeprintk("Couldn't get window property %d\n", dma_size);

Bert
N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ0¶ìh®å’i