Re: [PATCH 05/56] block: Remove void casts

From: Bert Wesarg
Date: Wed Apr 08 2009 - 08:03:35 EST


On Wed, Apr 8, 2009 at 13:38, Jack Stone <jwjstone@xxxxxxxxxxx> wrote:
> Bert Wesarg wrote:
>> Could you feed the patches through checkpatch.pl to find and fix these
>> style issues.
>>
>> (...)
>>
>> If typeof(c) == CommandList_struct*, that you could replace
>> sizeof(CommandList_struct) with sizeof(*c) to make the expression
>> shorter and fit into one line.
>>
> I was trying to avoid any changes beyond removing the void casts.
>
> I can go through and fix all these if people don't think thats too much to
> review in one go.
Right, thats a balancing act, and I think this change could be too much.

>
> I'll fix the line issues you've flagged up and resend the affected patched.
>

Bert
> Thanks,
>
> Jack
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/