Re: [PATCH] Don't export sched_mc_power_savings on multi-socketsingle core system

From: Ingo Molnar
Date: Wed Apr 08 2009 - 08:02:29 EST



* Mahesh Jagannath Salgaonkar <mahesh@xxxxxxxxxxxxxxxxxx> wrote:

> Fix to prevent sched_mc_power_saving from being exported through
> sysfs for multi-scoket single core system. Max cores should be
> always greater than one (1). My earlier patch that introduced fix
> for not exporting 'sched_mc_power_saving' on laptops broke it on
> multi-socket single core system. This fix addresses issue on both
> laptop and multi-socket single core system. Below are the Test
> results:

> +#define mc_capable() (boot_cpu_data.x86_max_cores > 1) && \
> + (cpumask_weight(cpu_core_mask(0)) != nr_cpu_ids)
> #define smt_capable() (smp_num_siblings > 1)

patch looks good but is whitespace damaged (all tabs were converted
to spaces). See Documentation/email-clients.txt about how to set up
your client.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/