Re: [PATCH 18/56] isdn: Remove void casts

[Bert Wesarg]

On Wed, Apr 8, 2009 at 13:21, Jack Stone <jwjstone@xxxxxxxxxxx> wrote:
> Remove uneeded void casts
>
> Signed-Off-By: Jack Stone <jwjstone@xxxxxxxxxxx>
> ---
> Âdrivers/isdn/hardware/eicon/capifunc.c Â| Â Â2 +-
> Âdrivers/isdn/hardware/eicon/diddfunc.c Â| Â Â2 +-
> Âdrivers/isdn/hardware/eicon/divasfunc.c | Â Â2 +-
> Âdrivers/isdn/hardware/eicon/divasi.c  Â|  27 ++++++++-------------------
> Âdrivers/isdn/hardware/eicon/idifunc.c  |  Â2 +-
> Âdrivers/isdn/hardware/eicon/mntfunc.c  |  Â2 +-
> Âdrivers/isdn/hardware/eicon/s_4bri.c  Â|  Â2 +-
> Âdrivers/isdn/hardware/eicon/um_idi.c  Â|  Â7 ++-----
> Â8 files changed, 16 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/isdn/hardware/eicon/divasi.c b/drivers/isdn/hardware/eicon/divasi.c
> index 69e71eb..9021581 100644
> --- a/drivers/isdn/hardware/eicon/divasi.c
> +++ b/drivers/isdn/hardware/eicon/divasi.c
> @@ -238,8 +238,7 @@ um_idi_read(struct file *file, char __user *buf, size_t count, loff_t * offset)
> Â Â Â Â}
>
> Â Â Â Âif (!
> - Â Â Â Â Â (p_os =
> - Â Â Â Â Â Â(diva_um_idi_os_context_t *) diva_um_id_get_os_context(file->
> + Â Â Â Â Â (p_os = diva_um_id_get_os_context(file->
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âprivate_data)))
Move this line up.

> Â Â Â Â{
And this brace too (or remove the brace all together, because its one
line statement body).

> Â Â Â Â Â Â Â Âreturn (-ENODEV);
> @@ -329,8 +328,7 @@ um_idi_write(struct file *file, const char __user *buf, size_t count,
> Â Â Â Â Â Â Â Â Â Â Â Âreturn (-ENODEV);
> Â Â Â Â}
>
> - Â Â Â if (!(p_os =
> - Â Â Â Â Â Â(diva_um_idi_os_context_t *) diva_um_id_get_os_context(file->
> + Â Â Â if (!(p_os = diva_um_id_get_os_context(file->
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âprivate_data)))
Dito.

> Â Â Â Â{
Dito.

> Â Â Â Â Â Â Â Âreturn (-ENODEV);

Bert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/