Re: [PATCH 11/11] w35und: make led lookup tables static

[Pavel Machek]

On Wed 2009-04-08 11:14:06, Pekka Enberg wrote:
> Impact: cleanup
> 
> No need to keep read-only data on the stack.

It would be enough to just put static to the variables. They would
still be off-stack, but would be local...

Anyway that's a detail.

Whole series:

Acked-by: Pavel Machek <pavel@xxxxxx>

> diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c
> index cffd732..dc7cc08 100644
> --- a/drivers/staging/winbond/wbusb.c
> +++ b/drivers/staging/winbond/wbusb.c
> @@ -171,14 +171,21 @@ static const struct ieee80211_ops wbsoft_ops = {
>  	.get_tsf		= wbsoft_get_tsf,
>  };
>  
> +static u8 LED_GRAY[20] = {
> +	0, 3, 4, 6, 8, 10, 11, 12, 13, 14, 15, 14, 13, 12, 11, 10, 8, 6, 4, 2
> +};
> +
> +static u8 LED_GRAY2[30] = {
> +	7, 8, 9, 10, 11, 12, 13, 14, 15, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> +	0, 15, 14, 13, 12, 11, 10, 9, 8
> +};
> +
>  static void hal_led_control(unsigned long data)
>  {
>  	struct wbsoft_priv *adapter = (struct wbsoft_priv *)data;
>  	struct hw_data *pHwData = &adapter->sHwData;
>  	struct wb35_reg *reg = &pHwData->reg;
>  	u32 LEDSet = (pHwData->SoftwareSet & HAL_LED_SET_MASK) >> HAL_LED_SET_SHIFT;
> -	u8 LEDgray[20] = { 0, 3, 4, 6, 8, 10, 11, 12, 13, 14, 15, 14, 13, 12, 11, 10, 8, 6, 4, 2 };
> -	u8 LEDgray2[30] = { 7, 8, 9, 10, 11, 12, 13, 14, 15, 0, 0, 0,
> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 15, 14, 13, 12, 11, 10, 9, 8 };


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/