Re: [PATCH] tracing/filters: use ring_buffer_discard_commit() infilter_check_discard()

[Ingo Molnar]

* Tom Zanussi <tzanussi@xxxxxxxxx> wrote:

> As for the other errors, it's the CONFIG_EVENT_TRACER not being 
> turned on again.  I think the tracing config patch below would be 
> a better solution than the one I previously posted...

Agreed, this is a very nice patch, i have applied it. I'll check 
whether this solves all the build problems.

This fits nicely into the 'tracing plugin life cycle' and basically 
this is what we want to see happen for ftrace plugins: they first 
start as standalone experiments. Once they prove to be useful and 
other tracer plugins desire its capabilities too, they become part 
of the tracing infrastructure, not part of a standalone plugin.

This gives some leeway in allowing people to do plugins even if 
plugin utility is not immediately obvious, and we can then observe 
its use and let features/capabilities percolate down into the core 
code.

There's also plugin functionality that works best when left 
standalone - they are specifically shaped for one very particular 
development activity: for example mmiotrace to debug drivers.

It's a bit like how Firefox developers manage their plugin space, 
and this concept seems to have worked well in a number of cases in 
the tracing tree too.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/