Re: [PATCH 2/2] sata_sil: disable DMA engine in ->freeze
From: Sagar Borikar
Date: Wed Apr 08 2009 - 01:13:44 EST
This patch works for our platform.
Thanks
Sagar
On Wed, Apr 8, 2009 at 4:53 AM, Jeff Garzik <jeff@xxxxxxxxxx> wrote:
>
> Dustin, please see if these two patches solve your problem?
>
>
> commit a6a2da59f2a4ba834a6e20e2d2a4d030bb9371ea
> Author: Jeff Garzik <jeff@xxxxxxxxxx>
> Date: Tue Apr 7 19:18:32 2009 -0400
>
> [libata] sata_sil: disable DMA engine in sil_freeze()
>
> We must disable the DMA engine before accessing taskfile registers.
>
> Signed-off-by: Jeff Garzik <jgarzik@xxxxxxxxxx>
>
> diff --git a/drivers/ata/sata_sil.c b/drivers/ata/sata_sil.c
> index e67ce8e..896975f 100644
> --- a/drivers/ata/sata_sil.c
> +++ b/drivers/ata/sata_sil.c
> @@ -565,6 +565,19 @@ static void sil_freeze(struct ata_port *ap)
> tmp |= SIL_MASK_IDE0_INT << ap->port_no;
> writel(tmp, mmio_base + SIL_SYSCFG);
> readl(mmio_base + SIL_SYSCFG); /* flush */
> +
> + /* Ensure DMA_ENABLE is off.
> + *
> + * This is because the controller will not give us access to the
> + * taskfile registers while a DMA is in progress
> + */
> + iowrite8(ioread8(ap->ioaddr.bmdma_addr) & ~SIL_DMA_ENABLE,
> + ap->ioaddr.bmdma_addr);
> +
> + /* According to ata_bmdma_stop, an HDMA transition requires
> + * on PIO cycle. But we can't read a taskfile register.
> + */
> + ioread8(ap->ioaddr.bmdma_addr);
> }
>
> static void sil_thaw(struct ata_port *ap)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/