Re: [GIT *] intel-iommu updates for 2.6.30 (second batch)

[David Woodhouse]

On Tue, 2009-04-07 at 08:15 +0200, Ingo Molnar wrote:
> * David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:
> 
> > I think the problem here is actually the fact that we used 
> > 'select' instead of proper dependencies. I wouldn't normally have 
> > used the abomination that is 'select', but since I was just moving 
> > things around I ended up doing so by accident.
> 
> Yeah, it's genuinely fragile.
> 
> > X2APIC currently selects INTR_REMAP, and the bug would never have 
> > happened if we'd made X2APIC _depend_ on INTR_REMAP instead.
> >
> > This is a better fix:
> 
> Yep, that patch looks better - it gets rid of a select and 
> establishes proper dependencies - applied it to x86/urgent
> and will get it to Linus later today.

Ta.

Signed-off-by: David Woodhouse <David.Woodhouse@xxxxxxxxx>

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@xxxxxxxxx                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/