Re: [PATCH] Add hvc_console to MAINTAINERS

From: Joe Perches
Date: Tue Mar 31 2009 - 17:42:07 EST


On Tue, 2009-03-31 at 14:22 -0700, Andrew Morton wrote:
> On Tue, 31 Mar 2009 14:10:23 -0700
> Joe Perches <joe@xxxxxxxxxxx> wrote:
> > On Tue, 2009-03-31 at 09:29 -0400, Josh Boyer wrote:
> > > Add a MAINTAINERS entry for the hypervisor virtual console support
> > > used on IBM POWER servers.
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index c5f4e9d..387ad45 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -2176,6 +2176,11 @@ W: http://www.ia64-linux.org/
> > > T: git kernel.org:/pub/scm/linux/kernel/git/aegl/linux-2.6.git
> > > S: Maintained
> > >
> > > +IBM HYPERVISOR VIRTUAL CONSOLE
> > > +P: Several
> > > +L: linuxppc-dev@xxxxxxxxxx
> > > +S: Maintained
> > > +
> > > IBM MCA SCSI SUBSYSTEM DRIVER
> > > P: Michael Lang
> > > M: langa2@xxxxxxxxxxxxxxxx
> >
> > I think this sort of entry should not be acceptable.
> > Maintainers should have individual names and contact addresses.
>
> There isn't a maintainer.
>
> But people send patches to the wrong list, so the ppc guys (who use
> this driver) don't get to see them.
>
> That's a practical, real-world problem. We should have a fix for it.
>
> > An exploder entry should be OK though.
> > For instance, the DVB subsystem:
> >
> > DVB SUBSYSTEM AND DRIVERS
> > P: LinuxTV.org Project
> > M: linux-media@xxxxxxxxxxxxxxx
> >
> > A list entry could be something like:
> >
> > P: Linux PCMCIA Team
> > L: linux-pcmcia@xxxxxxxxxxxxxxxxxxx
> >
>
> I'm unclear on what the difference is here..

I have no problem with the "L: list" entry.
I think that's good. Along with some file
matching pattern as well of course...

I think the "P: Several" entry is not good.

"Several" doesn't give any idea as to who
actually does the work.

If the "P:" entry is there at all, it should
be the list name.

Maybe "P: Linux PPC Development Team" or
something similar.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/