Re: [patch 18/35 xattr-rework] reiserfs: Clean up xattrs whenREISERFS_FS_XATTR is unset

From: Christoph Hellwig
Date: Tue Mar 31 2009 - 14:51:25 EST


On Mon, Mar 30, 2009 at 02:02:33PM -0400, Jeff Mahoney wrote:
> The current reiserfs xattr implementation will not clean up old xattr
> files if files are deleted when REISERFS_FS_XATTR is unset. This results
> in inaccessible lost files, wasting space.
>
> This patch compiles in basic xattr knowledge, such as how to delete them and
> change ownership for quota tracking. If the file system has never used
> xattrs, then the operation is quite fast: it returns immediately when
> it sees there is no .reiserfs_priv directory.

What about just making xattr suppose unconditional? That's what most
never filesystems do, and it really shouldn't be a whole lot of code.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/