Re: Regression caused by commit "netfilter: iptables: lock freecounters"

[Stephen Hemminger]

On Mon, 30 Mar 2009 14:08:08 +0200
Patrick McHardy <kaber@xxxxxxxxx> wrote:

> Roman Mindalev wrote:
> > On Mon, 30 Mar 2009 09:32:51 +0200
> > Eric Dumazet <dada1@xxxxxxxxxxxxx> wrote:
> > 
> >> Could you try following patch ?
> >>
> >> [PATCH] netfilter: use rcu_read_bh() in ipt_do_table()
> >>
> >> Commit 784544739a25c30637397ace5489eeb6e15d7d49
> >> (netfilter: iptables: lock free counters) forgot to disable BH
> >> in arpt_do_table(), ipt_do_table() and  ip6t_do_table()
> >>
> >> Use rcu_read_lock_bh() instead of rcu_read_lock() cures the problem.
> >>
> >> Reported-and-bisected-by: Roman Mindalev <r000n@xxxxxxxxx>
> >> Signed-off-by: Eric Dumazet <dada1@xxxxxxxxxxxxx>
> >> ---
> > 
> > 2.6.29-git4 and 2.6.29-git6 both works fine for me with this patch. 
> > Thanks, Eric!
> 
> Thanks indeed Eric :) Dave, please apply.
> 
> Acked-by: Patrick McHardy <kaber@xxxxxxxxx>
> 
> 
Acked-by: Stephen Hemminger <shemminger@xxxxxxxxxx>

The original version had rcu_read_lock_bh() but someone (not sure who)
talked me into removing it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/