Re: [PATCH 3/3] ext3: Avoid starting a transaction in writepagewhen not necessary

[Jan Kara]

 On Fri 27-03-09 19:03:41, Theodore Tso wrote:
> On Fri, Mar 27, 2009 at 11:23:46PM +0100, Jan Kara wrote:
> > On Fri 27-03-09 16:24:31, Theodore Ts'o wrote:
> > > From: Jan Kara <jack@xxxxxxx>
> > > 
> > > We don't have to start a transaction in writepage() when all the blocks
> > > are a properly allocated. Even in ordered mode either the data has been
> > > written via write() and they are thus already added to transaction's list
> > > or the data was written via mmap and then it's random in which transaction
> > > they get written anyway.
> > > 
> > > This should help VM to pageout dirty memory without blocking on transaction
> > > commits.
> > > 
> > > Signed-off-by: Jan Kara <jack@xxxxxxx>
> > > Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx>
> >   Please, use the patch below instead (and I'd also wait a few days for
> > Mingo to check whether it also helps him). It also changes data=writeback
> > mode in the same way and it adheres to coding style...
> 
> FYI, Looks like Linus has already cherry-picked your first patch from
> LKML and dropped it into mainline.  My other two patches haven't gone
> in yet as far as I can tell.
> 
> So we'll need to do a delta patch that has the differences from your
> new patch and what Linus has already pulled into mainline.
  Thanks for letting me know. Attached is a rediff against current
Linus's tree.

									Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR