Re: [PATCH] bonding: allow bond in mode balance-alb to work properlyin bridge -try4

From: Patrick McHardy
Date: Mon Mar 30 2009 - 08:58:29 EST


Jiri Pirko wrote:
Mon, Mar 30, 2009 at 02:47:59PM CEST, kaber@xxxxxxxxx wrote:
Jiri Pirko wrote:
Currently I'm thinking the way. What I have on mind:
I would like to add a list into struct net_device to contain all mac addresses
of the device. I would also like to use similar interface to handle them as
currently is for uc_list and mc_list. However I do not like that these lists are
not using standard list_head but they are propriate lists only for this purpose.
I'm thinking about converting them to use list_head first. Or maybe ignore them
and do the new list for macs in parallel?
Using list_heads in the address lists would require some pretty large
amount of work since you'd need to convert all the drivers.

Yes, I'm aware of it...
I'm all
in favour of doing this, but I wouldn't make the fix depend on that
work.

ok so you are suggesting to use the current list struct?

Whatever will make this easier :) You could of course already add the
new structure and use it for your new list and do the conversion of
the existing structures on top of that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/