Re: [patch 12/14] fs: dcache per-bucket dcache hash locking

From: Andi Kleen
Date: Mon Mar 30 2009 - 08:14:27 EST


npiggin@xxxxxxx writes:

> We can turn the dcache hash locking from a global dcache_hash_lock into
> per-bucket locking.

Per bucket locking is typically a bad idea because you get far too
many locks and you increase cache footprint with all of them. It's
typically better to use a second much smaller hash table that only has
locks (by just shifting the hash value down some more)
Just need to be careful to avoid too much false sharing.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/