Re: [PATCH v2 0/7] blktrace: last round of fixes

[Ingo Molnar]

* Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:

> Ingo Molnar wrote:
> > * Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:
> > 
> >> This is the last round of fixes for blktrace, I hope.  :) 
> >>
> >> Changelog v1 -> v2:
> >>   - fix a bug in "blktrace: make classic output more classic",
> >>     and rebase other patches.
> >>   - re-order patches.
> >>   - a new patch for filtering BLK_TN_MESSAGE
> >>
> >> [PATCH v2 1/6] trace: make 'mem' argument of trace_seq_putmem() const
> >> [PATCH v2 2/6] blktrace: make classic output more classic
> >> [PATCH v2 3/6] blktrace: fix blk_probes_ref chaos
> >> [PATCH v2 4/6] blktrace: fix memory leak when freeing struct blk_io_trace
> >> [PATCH v2 5/6] blktrace: extract duplidate code
> >> [PATCH v2 6/6] blktrace: print out BLK_TN_MESSAGE properly
> >> ---
> >>  blktrace.c     |  188 +++++++++++++++++++++++++++++++++------------------------
> >>  trace_output.c |    6 -
> >>  trace_output.h |    5 -
> >>  3 files changed, 117 insertions(+), 82 deletions(-)
> > 
> > Li, Jens - what's your call for v2.6.30, can the blktrace changes go 
> > upstream or should i zap the whole thing?
> > 
> 
> It should be fine to merge tip/blktrace into .30, and we still 
> have 2 month to fix remaining bugs, if any.

ok.

Although regarding instrumentation patches we carry in -tip we aim 
to enforce perfect stability right at the point of the merge window. 

One major point of instrumentation is to find kernel bugs ... and 
it's self-defeating if instrumentation is buggy itself! By the time 
the stable kernel is released the most important kernel bugs are 
fixed already so having stable instrumentation by that moment is too 
late.

So we've got extensive self-tests and other measures in place to 
ensure stability.

( The mixed blktrace ioctl/ftrace plugin usage model fell a bit
  outside of the expectation of these stability tests though, hence
  this relatively slow and late stabilization curve there. It still 
  looks all fine for .30 to me too. )

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/