Re: [git-pull -tip] x86: include inverse Xmas tree patches

From: Hugh Dickins
Date: Sat Mar 28 2009 - 11:17:20 EST


On Sat, 28 Mar 2009, Jaswinder Singh Rajput wrote:
> The following changes since commit 29219683c46cb89edf5c58418b5305b14646d030:
> Ingo Molnar (1):
> Merge branches 'x86/apic', 'x86/cleanups', 'x86/mm', 'x86/pat', 'x86/setup' and 'x86/signal'; commit 'v2.6.29' into x86/core
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-Xmas.git x86/core
>
> Jaswinder Singh Rajput (49):
> x86: process_32.c include inverse Xmas tree effect
> x86: signal.c include inverse Xmas tree effect
> x86: entry_32.S include inverse Xmas tree effect
> x86: traps.c include inverse Xmas tree effect
> x86: irq.c include inverse Xmas tree effect
> x86: irq_32.c include inverse Xmas tree effect
> x86: dumpstack.c include inverse Xmas tree effect
> x86: time_32.c include inverse Xmas tree effect
> x86: ioport.c include inverse Xmas tree effect
> x86: ldt.c include inverse Xmas tree effect
> x86: dumpstack_32.c include inverse Xmas tree effect
> x86: setup.c include inverse Xmas tree effect
> x86: i8259.c include inverse Xmas tree effect
> x86: irqinit_32.c include inverse Xmas tree effect
> x86: probe_roms_32.c include inverse Xmas tree effect
> x86: sys_i386_32.c include inverse Xmas tree effect
> x86: i386_ksyms_32.c include inverse Xmas tree effect
> x86: bootflag.c include inverse Xmas tree effect
> x86: e820.c include inverse Xmas tree effect
> x86: pci-dma.c include inverse Xmas tree effect
> x86: quirks.c include inverse Xmas tree effect
> x86: i8237.c include inverse Xmas tree effect
> x86: alternative.c include inverse Xmas tree effect
> x86: tsc.c include inverse Xmas tree effect
> x86: process.c include inverse Xmas tree effect
> x86: xsave.c include inverse Xmas tree effect
> x86: ptrace.c include inverse Xmas tree effect
> x86: ds.c include inverse Xmas tree effect
> x86: tls.c include inverse Xmas tree effect
> x86: step.c include inverse Xmas tree effect
> x86: stacktrace.c include inverse Xmas tree effect
> x86: reboot.c include inverse Xmas tree effect
> x86: msr.c include inverse Xmas tree effect
> x86: cpuid.c include inverse Xmas tree effect
> x86: early-quirks.c include inverse Xmas tree effect
> x86: smp.c include inverse Xmas tree effect
> x86: smpboot.c include inverse Xmas tree effect
> x86: tsc_sync.c include inverse Xmas tree effect
> x86: setup_percpu.c include inverse Xmas tree effect
> x86: trampoline_32.S include inverse Xmas tree effect
> x86: mpparse.c include inverse Xmas tree effect
> x86: module_32.c include inverse Xmas tree effect
> x86: doublefault_32.c include inverse Xmas tree effect
> x86: vm86_32.c include inverse Xmas tree effect
> ix86: early_printk.c include inverse Xmas tree effect
> x86: pcspeaker.c include inverse Xmas tree effect
> x86: head_32.c include inverse Xmas tree effect
> x86: head.c include inverse Xmas tree effect
> x86: init_task.c include inverse Xmas tree effect

Gasp.

Please find a better use for your time.

Imagine, there might be developers out there with real work
to do in these files: all you are doing is throwing silly
little obstacles in their way.

IMHO
Hugh

[snip most of it to leave one example]

> --- a/arch/x86/kernel/alternative.c
> +++ b/arch/x86/kernel/alternative.c
> @@ -1,17 +1,18 @@
> +#include <linux/kprobes.h>
> +#include <linux/vmalloc.h>
> #include <linux/module.h>
> -#include <linux/sched.h>
> #include <linux/mutex.h>
> +#include <linux/sched.h>
> #include <linux/list.h>
> -#include <linux/kprobes.h>
> #include <linux/mm.h>
> -#include <linux/vmalloc.h>
> +
> #include <asm/alternative.h>
> +#include <asm/cacheflush.h>
> #include <asm/sections.h>
> +#include <asm/vsyscall.h>
> #include <asm/pgtable.h>
> #include <asm/mce.h>
> #include <asm/nmi.h>
> -#include <asm/vsyscall.h>
> -#include <asm/cacheflush.h>
> #include <asm/io.h>
>
> #define MAX_PATCH_LEN (255-1)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/