Re: [PATCH 13/14] ide-atapi: use bio for request sense

[Borislav Petkov]

On Wed, Mar 25, 2009 at 01:06:15AM +0900, Tejun Heo wrote:
> Impact: unify request data buffer handling
> 
> rq->data is used mostly to pass kernel buffer through request queue
> without using bio.  There are only a couple of places which still do
> this in kernel and converting to bio isn't difficult.
> 
> This patch converts ide-atapi to use bio instead of rq->data.  For
> ide_queue_pc_tail() which can block, blk_rq_map_kern() is used.  For
> ide_queue_pc_head() which is used for request sense and called from
> atomic context, drive->request_sense_bio and ->request_sense_bvec[2]
> are added and used via bio_map_kern_prealloc().
> 
> ide-tape is updated to map sg for special requests.
> 
> This change makes all ide-atapi commands except for tape bh ones use
> bio.  Drop tp_ops->output/input_data path from ide_pc_intr().
> 
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Jens Axboe <axboe@xxxxxxxxx>

Acked-by: Borislav Petkov <petkovbb@xxxxxxxxx>

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/