Re: [PATCH]sunrpc/svc.c: Remove unused line 'rqstp->rq_server =serv;' in svc_process

From: J. Bruce Fields
Date: Fri Mar 27 2009 - 19:16:49 EST


On Thu, Mar 26, 2009 at 12:55:29PM +0800, ideawu wrote:
> There is no need to set rqstp->rq_server to serv, while serv is initialized as rqstp->rq_server at previous line. And between these two lines, there is no change to rqstp->rq_server.

Thanks! Applied.

>
> Signed-off-by: ideawu <ideawu@xxxxxxx>
> --------
>
> --- net/sunrpc/svc.c 2009-03-24 07:12:14.000000000 +0800
> +++ net/sunrpc/svc.mod.c 2009-03-26 09:39:15.187500000 +0800

(But next time please make sure the patch applies with 'patch -p1').

--b.

> @@ -1093,7 +1093,6 @@ svc_process(struct svc_rqst *rqstp)
> procp = versp->vs_proc + proc;
> if (proc >= versp->vs_nproc || !procp->pc_func)
> goto err_bad_proc;
> - rqstp->rq_server = serv;
> rqstp->rq_procinfo = procp;
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/