Re: [PULL REQUEST] Quota changes for 2.6.30

From: Jan Kara
Date: Fri Mar 27 2009 - 18:53:03 EST


On Fri 27-03-09 14:52:11, Linus Torvalds wrote:
> On Fri, 27 Mar 2009, Jan Kara wrote:
> > On Thu 26-03-09 16:16:47, Linus Torvalds wrote:
> > >
> > >
> > > On Thu, 26 Mar 2009, Jan Kara wrote:
> > > >
> > > > could you please pull from
> > > >
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-quota-2.6.git for_linus
> > >
> > > "Already up-to-date."
> > >
> > > Forgot to actually push it out?
> > Damn, you're right. Should be there now.
>
> It is, but now when I pull I notice that you hadn't used "-M --summary"
> when asking me to pull. You claimed:
>
> 66 files changed, 4770 insertions(+), 4565 deletions(-)
>
> but in fact it's really:
>
> 58 files changed, 902 insertions(+), 697 deletions(-)
> create mode 100644 fs/quota/Kconfig
> create mode 100644 fs/quota/Makefile
> rename fs/{ => quota}/dquot.c (85%)
> rename fs/{ => quota}/quota.c (94%)
> rename fs/{ => quota}/quota_tree.c (84%)
> rename fs/{ => quota}/quota_tree.h (100%)
> rename fs/{ => quota}/quota_v1.c (79%)
> rename fs/{ => quota}/quota_v2.c (98%)
> rename fs/{ => quota}/quotaio_v1.h (100%)
> rename fs/{ => quota}/quotaio_v2.h (100%)
>
> so please do change your pull-request script to add -M (for rename
> detection) and --summary (for that "new, deleted and renamed files"
> summary at the end).
OK, I didn't know this is the preferred way. Will do next time.

Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/