Re: [PATCH] Allow relatime to update atime once a day

[Bodo Eggert]

Matthew Garrett <mjg@xxxxxxxxxx> wrote:

> diff --git a/fs/inode.c b/fs/inode.c
> index 0487ddb..057c92b 100644
> --- a/fs/inode.c

>  now = current_fs_time(inode->i_sb);
> +
> +     if (!relatime_need_update(mnt, inode, now))
> +             goto out;
> +
>  if (timespec_equal(&inode->i_atime, &now))
>  goto out;

Forget what I just said, I should rather read than assume.

But I'm wondering if inlining this once-used function would be a good thing,
since relatime is supposed to be a common option? Otherwise, I'd pull the
flags check out and avoid the function call.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/