Re: [PATCH] v4l2: fill reserved fields of VIDIOC_ENUMAUDIO also

From: Mauro Carvalho Chehab
Date: Fri Mar 27 2009 - 12:17:49 EST


On Wed, 25 Mar 2009 17:51:39 +0100
Németh Márton <nm127@xxxxxxxxxxx> wrote:

> From: Márton Németh <nm127@xxxxxxxxxxx>
>
> When enumerating audio inputs with VIDIOC_ENUMAUDIO the gspca_sunplus driver
> does not fill the reserved fields of the struct v4l2_audio with zeros as
> required by V4L2 API revision 0.24 [1]. Add the missing initializations to
> the V4L2 framework.
>
> The patch was tested with v4l-test 0.10 [2] with gspca_sunplus driver and
> with Trust 610 LCD POWERC@M ZOOM webcam.

It didn't apply against the development tree. Anyway, a recent patch removed
the need of memset there. the memory fill with zero now happens at the same
code we copy the structure values.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/