Re: [PATCH] bonding: allow bond in mode balance-alb to workproperly in bridge -try4

From: David Miller
Date: Fri Mar 27 2009 - 03:38:46 EST


From: Jiri Pirko <jpirko@xxxxxxxxxx>
Date: Thu, 26 Mar 2009 16:52:06 +0100

> (resend, updated changelog, hook moved into skb_bond_should_drop,
> skb_bond_should_drop ifdefed)
>
> Hi all.
>
> The problem is described in following bugzilla:
> https://bugzilla.redhat.com/show_bug.cgi?id=487763
...
> This patch solves the situation in the bonding without touching bridge code,
> as Patrick suggested. For every incoming frame to bonding it searches the
> destination address in slaves list and if any of slave addresses matches, it
> rewrites the address in frame by the adress of bonding master. This ensures that
> all frames comming thru the bonding in alb mode have the same address.
>
> Signed-off-by: Jiri Pirko <jpirko@xxxxxxxxxx>


I don't like the hook, but if that's how it's best done....

Patrick, please review this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/