Re: [PATCH] af_rose/x25: Sanity check the maximum user frame size

From: David Miller
Date: Fri Mar 27 2009 - 03:29:45 EST


From: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 26 Mar 2009 21:58:51 +0000

> Otherwise we can wrap the sizes and end up sending garbage.
>
> Closes #10423
>
> Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>

Applied, but:

> - /* Build a packet */
> + /* Build a packet - the conventional user limit is 236 bytes. We can
> + do ludicrously large NetROM frames but must not overflow */
> + if (len > 65536)
> + return -EMSGSIZE;
> +
^^^^^^^^^^^^^

please fix the tab monster :-) Or, alternatively, check the patch
either with GIT's automatic checks (or using checkpatch.pl if you
haven't eaten recently)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/