Re: RDMA/nes: Fix mis-merge

From: Roland Dreier
Date: Thu Mar 26 2009 - 19:53:54 EST


> Btw, as far as I can tell, that function had never been tested with any
> polling. It had a line like
>
> netif_napi_add(netdev, &nesvnic->napi, nes_netdev_poll, 128);
>
> but that line was _before_ 'nesvnic' was actually initialized (well, it
> had been initialized to NULL, so it passed in some NULL-pointer-offset to
> that function).

Yes, looks like the bug was introduced by d0929553 ("infiniband: convert
nes driver to net_device_ops"). And unfortunately the nesvnic=NULL
initialization stopped gcc from warning about used-uninitialized I
guess. I'll test the final merge out...

- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/