Re: [PATCH] writeback: reset inode dirty time when adding it backto empty s_dirty list

[Jeff Layton]

On Wed, 25 Mar 2009 22:16:18 +0800
Wu Fengguang <fengguang.wu@xxxxxxxxx> wrote:

> > 
> > Actually, I think you were right. We still have this check in
> > generic_sync_sb_inodes() even with Wu's January 2008 patches:
> > 
> > 	/* Was this inode dirtied after sync_sb_inodes was called? */
> > 	if (time_after(inode->dirtied_when, start))
> > 		break;
> 
> Yeah, ugly code. Jens' per-bdi flush daemons should eliminate it...
> 

I had a look over Jens' patches and they seem to be more concerned with
how the queues and daemons are organized (per-bdi rather than per-sb).
The actual way that inodes flow between the queues and get written out
don't look like they really change with his set.

They also don't eliminate the problematic check above. Regardless of
whether your or Jens' patches make it in, I think we'll still need
something like the following (untested) patch.

If this looks ok, I'll flesh out the comments some and "officially" post
it. Thoughts?

--------------[snip]-----------------