Re: [RFC][PATCH 2/3] perf_counter: executable mmap() information

[Paul Mackerras]

Ingo Molnar writes:

> * Paul Mackerras <paulus@xxxxxxxxx> wrote:
> 
> > Peter Zijlstra writes:
> > 
> > > --- linux-2.6.orig/include/linux/perf_counter.h
> > > +++ linux-2.6/include/linux/perf_counter.h
> > > @@ -137,7 +137,9 @@ struct perf_counter_hw_event {
> > >  				exclude_kernel :  1, /* ditto kernel          */
> > >  				exclude_hv     :  1, /* ditto hypervisor      */
> > >  				exclude_idle   :  1, /* don't count when idle */
> > > -				include_tid    :  1, /* include the tid */
> > > +				include_tid    :  1, /* include the tid       */
> > > +				mmap           :  1, /* include mmap data     */
> > > +				munmap         :  1, /* include munmap data   */
> > >  
> > >  				__reserved_1   : 54;
> > 
> > Nit: need to adjust the size of __reserved_1 here.  Or maybe just 
> > get rid of it?
> 
> it's nice to have a constant reminder about how many bits there are 
> left.

Fair enough, but as it stands, we've changed the ABI, so we need to
fix it.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/