Re: [PATCH] reiserfs: select CRC32 and BITREVERSE for REISERFS_FSKconfig entry

[Coly Li]

Randy Dunlap Wrote:
> Coly Li wrote:
>> In patch fs-reiserfs-return-f_fsid-for-statfs2-v2.patch (from mmotm), crc32_le()
>> is referenced. If reiserfs is compiled into kernel and crc32_le() is compiled as
>> kernel module, there might be a compiling error as:
>>     fs/built-in.o: In function `reiserfs_statfs':
>>     super.c:(.text+0x7332b): undefined reference to `crc32_le'
>>     super.c:(.text+0x7333f): undefined reference to `crc32_le'
>> This patch select CRC32 and BITREVERSE for REISERFS_FS Kconfig entry, which
>> indicates compiling crc32_le() into kernel.
>>
>> Thanks to Randy Dunlap for pointing out this error and providing helpful solution.
>>
>> Signed-off-by: Coly Li <coly.li@xxxxxxx>
>> Cc: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> 
> Acked-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Tested-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>

Hi Randy,

You give me an important enlightenment, for my return-f_fsid-for-statfs2 patch
serial, selecting CRC32 and BITREVERSE is necessary ...

Andrew,

I will check it and send out fix ASAP.

Thanks.

-- 
Coly Li
SuSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/