Re: [tip:sched/balancing] sched: Add comments to find_busiest_group() function

[Ray Lee]

This commit says it's just adding comments, but...

On Wed, Mar 25, 2009 at 5:30 AM, Gautham R Shenoy <ego@xxxxxxxxxx> wrote:
> Commit-ID: Âb7bb4c9bb01941fe8feb653f3410e7ed0c9bb786
> Gitweb: Â Â http://git.kernel.org/tip/b7bb4c9bb01941fe8feb653f3410e7ed0c9bb786
> Author: Â Â Gautham R Shenoy <ego@xxxxxxxxxx>
> AuthorDate: Wed, 25 Mar 2009 14:44:27 +0530
> Committer: ÂIngo Molnar <mingo@xxxxxxx>
> CommitDate: Wed, 25 Mar 2009 13:28:30 +0100
>
> sched: Add comments to find_busiest_group() function
>
> Impact: cleanup
>
> Add /** style comments around find_busiest_group(). Also add a few
> explanatory comments.

...but there are actual code changes. Hard to know if you intended to
do that and forgot to changelog it, or if it's an unexpected hunk that
accidentally got included:

> Â Â Â Âif (balance && !(*balance))
> Â Â Â Â Â Â Â Âgoto ret;
>
> - Â Â Â if (!sds.busiest || sds.this_load >= sds.max_load
> - Â Â Â Â Â Â Â || sds.busiest_nr_running == 0)
> + Â Â Â if (!sds.busiest || sds.busiest_nr_running == 0)
> + Â Â Â Â Â Â Â goto out_balanced;
> +
> + Â Â Â if (sds.this_load >= sds.max_load)
> Â Â Â Â Â Â Â Âgoto out_balanced;
>
> Â Â Â Âsds.avg_load = (SCHED_LOAD_SCALE * sds.total_load) / sds.total_pwr;
>
> - Â Â Â if (sds.this_load >= sds.avg_load ||
> - Â Â Â Â Â Â Â Â Â Â Â 100*sds.max_load <= sd->imbalance_pct * sds.this_load)
> + Â Â Â if (sds.this_load >= sds.avg_load)
> + Â Â Â Â Â Â Â goto out_balanced;
> +
> + Â Â Â if (100 * sds.max_load <= sd->imbalance_pct * sds.this_load)
> Â Â Â Â Â Â Â Âgoto out_balanced;
>
> Â Â Â Âsds.busiest_load_per_task /= sds.busiest_nr_running;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/