Re: [PATCH 0/5] [PATCH][GIT PULL] remove unnecessary (un)likelys

[Steven Rostedt]

On Wed, 25 Mar 2009, Ingo Molnar wrote:

> 
> * Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> 
> > ----
> >  arch/x86/kernel/ptrace.c |    4 ++--
> >  kernel/sched.c           |    4 ++--
> >  kernel/sched_rt.c        |    2 +-
> >  mm/rmap.c                |    8 ++++----
> >  mm/slab.c                |    2 +-
> >  mm/slob.c                |    2 +-
> >  mm/slub.c                |    2 +-
> >  7 files changed, 12 insertions(+), 12 deletions(-)
> 
> I commented on the ptrace one - i think we should take that one out 
> or at least wait for more info.
> 
> The MM ones look correct. Maybe your kfree observation will be 
> debated - but i think it's probably right that we should not special 
> annotate kfree(NULL) anymore in any direction. But it's ultimately 
> up to the MM folks. (I've Cc:-ed Pekka too)
> 
> The rmap and the scheduler ones definitely look correct. When you 
> rebase, please include the profiler output to 3/5 too.

I'll rebase it to only include the non controversial changes.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/