RE: [PATCH 12/13][Resubmit][drivers/media] changed ioctls tounlocked

[Aguirre Rodriguez, Sergio Alberto]

Hi Stoyan,

> -----Original Message-----
> From: linux-media-owner@xxxxxxxxxxxxxxx [mailto:linux-media-
> owner@xxxxxxxxxxxxxxx] On Behalf Of stoyboyker@xxxxxxxxx
> Sent: Tuesday, March 24, 2009 3:39 PM
> To: linux-kernel@xxxxxxxxxxxxxxx
> Cc: Stoyan Gaydarov; linux-media@xxxxxxxxxxxxxxx
> Subject: [PATCH 12/13][Resubmit][drivers/media] changed ioctls to unlocked
> 
> From: Stoyan Gaydarov <stoyboyker@xxxxxxxxx>
> 
> Signed-off-by: Stoyan Gaydarov <stoyboyker@xxxxxxxxx>
> ---
>  drivers/media/dvb/bt8xx/dst_ca.c |    7 +++++--
>  drivers/media/video/dabusb.c     |   11 ++++++++---
>  2 files changed, 13 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/media/dvb/bt8xx/dst_ca.c
> b/drivers/media/dvb/bt8xx/dst_ca.c
> index 0258451..d3487c5 100644
> --- a/drivers/media/dvb/bt8xx/dst_ca.c
> +++ b/drivers/media/dvb/bt8xx/dst_ca.c
> @@ -552,8 +552,10 @@ free_mem_and_exit:
>  	return result;
>  }
> 
> -static int dst_ca_ioctl(struct inode *inode, struct file *file, unsigned
> int cmd, unsigned long ioctl_arg)
> +static long dst_ca_ioctl(struct file *file, unsigned int cmd, unsigned
> long ioctl_arg)
>  {
> +	lock_kernel();
> +

Why moving to unlocked_ioctl if you're acquiring the Big Kernel Lock anyways?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/