Re: [PATCH 07/13] [usb] changed ioctls to unlocked

[Greg KH]

On Tue, Mar 24, 2009 at 04:12:42PM -0500, stoyboyker@xxxxxxxxx wrote:
> From: Stoyan Gaydarov <stoyboyker@xxxxxxxxx>
> 
> Signed-off-by: Stoyan Gaydarov <stoyboyker@xxxxxxxxx>
> ---
>  drivers/usb/mon/mon_bin.c |   53 ++++++++++++++++++++++++++++++++------------
>  1 files changed, 38 insertions(+), 15 deletions(-)

NAK, you're just pushing lock_kernel() down for no good reason.

the code should be fixed to not need the lock at all.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/