Re: [PATCH] bonding: allow bond in mode balance-alb to work properlyin bridge

From: Stanichenko Marat
Date: Tue Mar 24 2009 - 05:55:15 EST


Thu, Mar 19, 2009 at 11:21:43AM CET, davem@xxxxxxxxxxxxx wrote:
From: Jiri Pirko <jpirko@xxxxxxxxxx>
Date: Thu, 19 Mar 2009 09:44:45 +0100

Yes I was looking at this thing yesterday (uc_list). But this list serves
to different purpose. Do you think that it will be correct to use it for this? I
would maybe like to make a new list similar to this for our purpose
(say addr_list). I think it would be more correct.

Whatever you do with that list privately inside of the bonding
driver should be fine.
Well I do not need it only inside the bonding driver. I want bridge to use this
list when adding a device in it and get mac addresses from there into its
hashlist (to recognize these addresses as local).
Please correct me if I understand you improperly. You're going to mark all mac addresses that belong to slaves as "local" when adding a bond device to the bridge, aren't you? The only thing I'd like to notice (this might be an obvious one): a packet that is pushed out from one slave might reach the host through another slave. Considering all slaves as "local" in bridge code might lead to numerous messages "received packet with own address as source address".

Please CC me personally when answering this message.

Thanks,
Marat.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/