Re: [GIT PATCH] block: cleanup patches

From: Jens Axboe
Date: Sun Mar 15 2009 - 12:45:37 EST


On Sat, Mar 14 2009, Tejun Heo wrote:
> Tejun Heo wrote:
> > Hello,
> >
> > This patchset is available in the following git tree.
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git block-cleanup
> >
> > This patchset contains the following 14 cleanup patches.
>
> Jens, once you're okay with the rest of the changes, I'll remove IDE
> related stuff and repost the patchset.

I only gave it a quick glance, looks mostly OK. Though I don't like
putting elv_ prefixed stuff in blk-core. I agree it belongs there
though, it's really block layer functionality and not io scheduler
interfacing. So rename it blk_ instead and put compatability names in
the header file instead.

I'll give it a more thorough review and integration test tomorrow.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/