Re: [Tux3] Tux3 report: Tux3 Git tree available

From: OGAWA Hirofumi
Date: Sun Mar 15 2009 - 00:27:22 EST


Daniel Phillips <phillips@xxxxxxxxx> writes:

>> BTW, those are almost because of userland issue. Kernel are more and
>> more using same type. But, glibc is not. And we (tux3) are sharing the
>> same code with kernel and userland. Some types are depending to
>> CONFIG_*, so if we have generic cast type like (L).
>>
>> [The fatfs also has own type (llu), if it become generic, fatfs will
>> also be happy.]
>>
>> Thanks.
>
> Maybe we should argue for some generic flavor of the (L)/(llu) idea
> then. I suppose we should figure out exactly how much of our usage
> will remain after the kernel issue is resolved. One small thing we
> could do is make it a typedef instead of a macro.

It is already typedef?

typedef long long L; // widen for printf on 64 bit systems

> And spelling it out completely as (long long) is not so bad, except it
> loses the desirable property of being able to grep for the messy
> thing, and adds a painful amount of useless line length, given how
> frequently the issue shows up.

Yes. Well, it is depending on the warn/info/trace strategy of the
modules. I guess so many modules are not requiring it, because there is
no trace. But, if those are implementing the trace code or something
like it, I guess (long long) will bother devlopers.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/