Re: [PATCH] x86: relocs is only used with 32bit

From: H. Peter Anvin
Date: Fri Mar 13 2009 - 19:33:24 EST


Eric W. Biederman wrote:

In general I prefer minimizing the conditional sections rather than
maximizing them. If nothing else, it catches errors earlier that way,
and makes it easier to eventually eliminate them entirely.

Makes sense. Although in this case that rule appears like it
can't even execute on x86_64.


That's fine. This is the same reason why it's better to have
if () { ... } than #ifdef as long as the condition can be statically determined -- at least this way make will complain about a syntax error.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/