Re: [PATCH] phylib: convert state_queue work to delayed_work

[David Miller]

From: Jean Delvare <khali@xxxxxxxxxxxx>
Date: Sat, 7 Mar 2009 10:46:20 +0100

> On Fri, 6 Mar 2009 21:51:42 +0100, Marcin Slusarz wrote:
> > It closes a race in phy_stop_machine when reprogramming of phy_timer
> > (from phy_state_machine) happens between del_timer_sync and cancel_work_sync.
> > 
> > Without this change it could lead to crash if phy_device would be freed after
> > phy_stop_machine (timer would fire and schedule freed work).
> > 
> > Signed-off-by: Marcin Slusarz <marcin.slusarz@xxxxxxxxx>
> > Cc: Andy Fleming <afleming@xxxxxxxxxxxxx>
> > Cc: Trent Piepho <tpiepho@xxxxxxxxxxxxx>
> > ---
> > 
> > This patch was only compile tested.
> 
> Patch looks good.
> 
> Acked-by: Jean Delvare <khali@xxxxxxxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/