Re: [PROBLEM]: potential unaligned memory access indrivers/usb/gadget/rndis.c

[David Miller]

From: Harvey Harrison <harvey.harrison@xxxxxxxxx>
Date: Thu, 12 Mar 2009 16:51:37 -0700

> On Wed, 2009-03-11 at 23:51 -0700, Andrew Morton wrote:
> 
> > Maybe the below fixed this?  afacit it is queued for 2.6.30 in the
> > net-next tree: 
> > 
> > commit 35c26c2cf6a6a2d1c48add732d8ba002bd90784c
> > Author:     Harvey Harrison <harvey.harrison@xxxxxxxxx>
> > AuthorDate: Sat Feb 14 22:56:56 2009 -0800
> > Commit:     David S. Miller <davem@xxxxxxxxxxxxx>
> > CommitDate: Sat Feb 14 22:56:56 2009 -0800
> > 
> >     rndis: remove private wrapper of __constant_cpu_to_le32
> >     
> >     Use cpu_to_le32 directly as it handles constant folding now, replace direct
> >     uses of __constant_cpu_to_{endian} as well.
> >     
> >     Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> >     Acked-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> >     Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> > 
> 
> Doubtful, this patch should be a no-op, any alignment problems that existed
> before will still be there.

Agreed, that patch won't do anything wrt. the alignment issue being
reported here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/