Re: [patch 1/5] x86, bts: detect size of DS fields

From: Ingo Molnar
Date: Fri Mar 13 2009 - 07:04:31 EST



Applied your patches to tip:tracing/hw-branch-tracer, thanks
Markus!

I did a small cleanup patch - see it in this thread.

One detail i noticed:

static DEFINE_PER_CPU(struct ds_configuration, ds_cfg_array);

That PER_CPU indirection should be removed - it's enough to have
system-wide configuration settings. We dont generally support
assymetric CPU capabilities in the same system, and the per_cpu
indirection here slows the code down and obfuscates it.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/